fix: should not include reasoning text in the chat completion request #6072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 0b1b84d in 59 seconds. Click for details.
- Reviewed
75lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/lib/__tests__/messages.test.ts:411
- Draft comment:
New tests for analysis-channel reasoning removal are comprehensive; they cover cases with and without final tags and multiline content. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/src/lib/messages.ts:105
- Draft comment:
The added regex for removing analysis reasoning text works as intended; consider extracting the regex pattern into a constant for improved readability. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_2TRusYG2N1aHDmHU
You can customize 
qnixsynapse
approved these changes
Aug 6, 2025
Minh141120
approved these changes
Aug 6, 2025
urmauur
approved these changes
Aug 6, 2025
Barecheck - Code coverage reportTotal: 33.18%Your code coverage diff: 0.03% ▴ ✅ All code changes are covered |
louis-jan
deleted the
fix/should-not-include-reasoning-content-in-completion-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Reasoning text should not be included in the completion's assistant message. This PR is to fix this.
Issue:
Fixes Issues
Self Checklist